By monitoring the by-product generated in the process of combined chlorine disinfection for raw water from Huangpu River and taking homogeneity, generation model of DBPs in chlorine disinfection for raw water was to be studied.The experiment result indicated that the highest concentration of trihalomethane and haloacetic acids generated in the process of combined chlorine disinfection for raw water from Huangpu River mainly accured in summer, when the temperature is relatively high. And in one year, the lowest and highest concentration of trihalomethane and haloacetic acids was measuced. The correlation of generation between UV254 and trihalomethane was high and the coefficient was more than 0.7. The correlation of generation between haloacetic acids and substitute parameter of organic matter was lower and the coefficient was less than 0.2. The average removal efficiency of trihalomethane and haloacetic acids was about 20%. And last, the generation model of trihalomethane and haloacetic acids generated in the process of combined chlorine disinfection for raw water from Huangpu River.